Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/worker/server: return an error on depsolve timeout (HMS-2989) #4398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

internal/worker/server: return an error on depsolve timeout (HMS-2989) #4398

wants to merge 1 commit into from

Conversation

schuellerf
Copy link
Contributor

@schuellerf schuellerf commented Oct 4, 2024 •
edited
Loading

Fixes the special case that if no worker is available and we generate an internal timeout and cancel the depsolve, including all followup jobs, no error was propagated.

For details, see https://issues.redhat.com/browse/HMS-2989

Now all jobs (in the DB) are set to "failed":

  • All jobs entries get a "job_error" in the result as well as
  • started_at and failed_at are set to "now" and
  • token is set to a random UUID to comply with the DB schema

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

This is set to draft for now until:

  • I get feedback that this approach is ok
  • tests are implemented
  • we decided on if we should "create a separate metrics" (see comment in the code)

@schuellerf schuellerf force-pushed the return-error-on-depsolve-timeout-hms-2989 branch from fe07345 to 82a6126 Compare October 4, 2024 10:51
@schuellerf
Copy link
Contributor Author

schuellerf commented Oct 4, 2024 •
edited
Loading

On the frontend this looks like this:

@schuellerf
internal/worker/server: return an error on depsolve timeout HMS-2989
54dca59 
Fixes the special case that if no worker is available and we
generate an internal timeout and cancel the depsolve including all
followup jobs, no error was propagated.
@schuellerf schuellerf force-pushed the return-error-on-depsolve-timeout-hms-2989 branch from 82a6126 to 54dca59 Compare October 4, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croissanne croissanne Awaiting requested review from croissanne

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🌟 best practice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuellerf @schutzbot