Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge:add iot-simplified-installer test case #3895

Closed
wants to merge 1 commit into from

Conversation

yih-redhat
Copy link
Contributor

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@yih-redhat yih-redhat added the WIP Work in progress. Don't run Gitlab CI. label Jan 17, 2024
@yih-redhat yih-redhat force-pushed the test-iot-simple branch 2 times, most recently from 2dc4bb8 to ab0d94b Compare January 18, 2024 09:09
Copy link
Member

@henrywang henrywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yih-redhat Your change caused simpflied-installer-fips test failed. Could you please take a look? Thanks.

@yih-redhat
Copy link
Contributor Author

Blocked by bug fdo-rs/fido-device-onboard-rs#605

@yih-redhat
Copy link
Contributor Author

@yih-redhat Your change caused simpflied-installer-fips test failed. Could you please take a look? Thanks.

Sure, I will re-run this case later after fdo-aio bug fixed.

@yih-redhat
Copy link
Contributor Author

Hi @mmartinv , the CI job edge-simplified-9-fips failed with this error:

TASK [run 'fips-mode-setup --check'] *******************************************
changed: [192.168.100.50] => {"changed": true, "cmd": ["fips-mode-setup", "--check"], "delta": "0:00:00.022434", "end": "2024-01-23 22:46:28.622064", "msg": "", "rc": 0, "start": "2024-01-23 22:46:28.599630", "stderr": "", "stderr_lines": [], "stdout": "Installation of FIPS modules is not completed.\nFIPS mode is disabled.", "stdout_lines": ["Installation of FIPS modules is not completed.", "FIPS mode is disabled."]}

it's strange because the first case(without fido) and second case(with fido insecure) passed, but failed at third case(with fido sshkey). And the same case can pass in our downstream CI https://github.com/virt-s1/rhel-edge/blob/main/ostree-simplified-installer.sh
Re-run this failed case several times and error still there. I didn't see anything special in fido sshkey case, neither any code change in this pr that could cause fips fail.
I am still looking at this failure, appreciate if you can take a look when you have time.

password = "${EDGE_USER_PASSWORD_SHA512}"
key = "${SSH_KEY_PUB}"
home = "/home/simple/"
groups = ["wheel"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[customizations.user]] must be added before [customizations] or after adding fips=true, otherwise it will break the blueprint definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmartinv !
I fixed this error and will trigger CI test again.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 25, 2024
Copy link

github-actions bot commented Mar 3, 2024

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale WIP Work in progress. Don't run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants