Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade to Go 1.22 #1396

Merged
merged 1 commit into from
Nov 29, 2024
Merged

build(deps): upgrade to Go 1.22 #1396

merged 1 commit into from
Nov 29, 2024

Conversation

lzap
Copy link
Collaborator

@lzap lzap commented Nov 11, 2024

Upgrading to UBI9 Go 1.22 starting top to bottom (IB first, composer then, images library last).

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 5 files with indirect coverage changes

@ezr-ondrej
Copy link
Collaborator

ezr-ondrej commented Nov 11, 2024

gosec will need a go bump too
UPDATE: And containerfile ;)

@lzap
Copy link
Collaborator Author

lzap commented Nov 11, 2024

Bumped gosec, containerfile is set to latest so no update is needed until it is released.

@lzap
Copy link
Collaborator Author

lzap commented Nov 11, 2024

For the record, it is failing because our CI pulls from a mirror or something. Not sure, let`s try to rebase after it is fully published. It hasn’t been announced yet.

@lzap
Copy link
Collaborator Author

lzap commented Nov 15, 2024

Since RHEL 9.5 is out, let's try now.

@croissanne
Copy link
Member

Hmm, the latest go toolset container is still 1.21?

sanne@worky ~ $ sudo podman run -it registry.access.redhat.com/ubi9/go-toolset:latest  bash
bash-5.1$ go version
go version go1.21.10 (Red Hat 1.21.10-1.el9_4) linux/amd64

I suppose it didn't get updated to 9.5 yet.

@lzap
Copy link
Collaborator Author

lzap commented Nov 29, 2024

Aaaand it is up:

$ go version
go version go1.22.7 (Red Hat 1.22.7-2.el9_5) linux/amd64

Rebased.

Copy link
Collaborator

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🧡

@ezr-ondrej ezr-ondrej merged commit fcd5365 into osbuild:main Nov 29, 2024
16 checks passed
@lzap lzap deleted the go122 branch November 29, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants