fedora-bot: Continue after failure #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkoniu
force-pushed
the
continue-on-failure
branch
from
460da7b
to
f795271
Compare
thozza
reviewed
Sep 10, 2024
fedora_bot.py
Outdated
Comment on lines
339
to
340
| except: | ||
| print(f"Failure in processing component [{component}] - skipping") |
There was a problem hiding this comment.
Is there a specific exception that we could be catching? In addition, I think that it would be good to actually print the exception message, potentially with the traceback as part of the message. Otherwise we are loosing potentially useful information, which would make debugging harder.
There was a problem hiding this comment.
I have updated the code, hope it looks better now :)
There was a problem hiding this comment.
My proposition would be to evaluate this code next time it will fail and start adding detected exceptions one by one (and eventually handle them specified ways).
Fedora Bot can handle more than one component to be processed. The components are processed one by one in the loop. When processing of component fails it breaks the loop. This commit fixes this adding exception for such case and continuing with the next component.
elkoniu
force-pushed
the
continue-on-failure
branch
from
f795271
to
b97ac36
Compare
thozza
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora Bot can handle more than one component to be processed. The components are processed one by one in the loop. When processing of component fails it breaks the loop. This commit fixes this adding exception for such case and continuing with the next component.