Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align testing with cockpit-project #2044

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Align testing with cockpit-project #2044

merged 5 commits into from
Aug 22, 2024

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Aug 20, 2024 •
edited
Loading

Cockpit defines their gating tests upstream, in test/browser, let's do the same.

@croissanne croissanne marked this pull request as draft August 20, 2024 15:40
@croissanne croissanne force-pushed the tmt-upstream branch 6 times, most recently from 753ba9e to 1045991 Compare August 21, 2024 08:17
@croissanne croissanne marked this pull request as ready for review August 21, 2024 08:23
kingsleyzissou
kingsleyzissou previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, from what I can tell. Do we want to try ask for one of the cockpit team to give a review too?

@croissanne
Copy link
Member Author

Looks good to me, from what I can tell. Do we want to try ask for one of the cockpit team to give a review too?

Just did! I'll wait for a look over from them.

martinpitt
martinpitt requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @croissanne this makes sense! However, to really validate this I recommend to actually enable at least one OS in your packit config, so that they run in upstream PRs. After all, you want to shift left the gating tests, no? Otherwise this will just bitrot.

test/browser/browser.sh Outdated Show resolved Hide resolved
@martinpitt
Copy link
Collaborator

Note that COPR has some serious problems today, builds take ages.. so the TF results will also take a while, but they do come in eventually.

@martinpitt
Copy link
Collaborator

@croissanne I saw some "is it just.." question fly by, apparently you removed the comment. But the extra commit looks good in general. You mostly need to keep the targets: list up to date and to what you support in main. So let's wait for the results! ☕

martinpitt
martinpitt previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, bots have the last word.

@martinpitt
Copy link
Collaborator

@croissanne FTR, your downstream dist-git still needs two things: The .fmf/version stamp and a plan that runs the tests from the dist-git's source tarball.

@croissanne
Copy link
Member Author

@croissanne FTR, your downstream dist-git still needs two things: The .fmf/version stamp and a plan that runs the tests from the dist-git's source tarball.

will add those as soon as the tests succeed here

@croissanne
Copy link
Member Author

@croissanne FTR, your downstream dist-git still needs two things: The .fmf/version stamp and a plan that runs the tests from the dist-git's source tarball.

OH ic of course it fetches the tests from dist-git 🤦 will do that now.

@croissanne
Copy link
Member Author

/packit test

@kingsleyzissou
Copy link
Contributor

Weird, looks like some of those rpm builds completed successfully. But the jobs are still pending

@croissanne
Copy link
Member Author

Weird, looks like some of those rpm builds completed successfully. But the jobs are still pending

naw it's the srpm jobs that are completed. Copr is rlly struggling still
afbeelding

https://copr.fedorainfracloud.org/status/stats/

@croissanne croissanne force-pushed the tmt-upstream branch 5 times, most recently from 5f66111 to 15e0176 Compare August 21, 2024 22:41
@croissanne
.cockpit-ci: add tasks container
586e396 
This container is used to run the tests, this provides a consistent test
environment for downstream tests. The actual tests run against a host
with the target distribution of course.
@croissanne croissanne requested review from kingsleyzissou and removed request for kingsleyzissou August 22, 2024 07:55
@croissanne croissanne force-pushed the tmt-upstream branch 3 times, most recently from d0478e3 to 6b0071f Compare August 22, 2024 09:27
@croissanne
test/browser: add browser tests
c5478be 
These tests are used by test management tool for the dist-git gating
tests. This was mostly copied from cockpit-project/starter-kit.
@croissanne
Makefile: remove machine target
114fa7a
@croissanne
test: let vm.install work both locally and with tmt
2a309bd
@croissanne
packit.yml: run gating tests on PRs
b060c69
kingsleyzissou
kingsleyzissou approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@croissanne croissanne merged commit 1d443f4 into osbuild:main Aug 22, 2024
29 of 30 checks passed
@croissanne croissanne deleted the tmt-upstream branch August 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingsleyzissou kingsleyzissou kingsleyzissou approved these changes

@martinpitt martinpitt martinpitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@croissanne @martinpitt @kingsleyzissou