Skip to content

Commit

Permalink
ImportBlueprint: scope file preview min-height to just this component
Browse files Browse the repository at this point in the history 
823c4f1 introduced min-height to all file
upload previews. However, we don't want to have min-height for all of them,
and especially not for those that have hideDefaultPreview="true". For these,
having the "global" min-height causes 30rem of empty vertical space to appear,
which breaks certain stuff. An example is the UploadOCIFile component used
in Oracle Cloud uploads.

Fix this by scoping the CSS rule to just the ImportBlueprint component.
  • Loading branch information
@ondrejbudai @jkozol
ondrejbudai authored and jkozol committed Aug 28, 2023
1 parent 23850e4 commit 68980e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/Modal/ImportBlueprint.css
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.pf-c-file-upload__file-details {
.import-blueprint-file-upload .pf-c-file-upload__file-details {
min-height: 30rem;
}
1 change: 1 addition & 0 deletions src/components/Modal/ImportBlueprint.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const ImportBlueprint = () => {
>
<FileUpload
type="text"
className="import-blueprint-file-upload"
value={blueprint}
filename={filename}
filenamePlaceholder={intl.formatMessage({
Expand Down

1 comment on commit 68980e3

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your Packit configuration the settings of the @osbuild/cockpit-composer Copr project would need to be updated as follows:

field old value new value
chroots ['epel-8-x86_64'] ['centos-stream-8-x86_64', 'centos-stream-9-x86_64', 'epel-8-x86_64', 'epel-9-x86_64', 'fedora-37-x86_64', 'fedora-38-x86_64', 'fedora-39-x86_64', 'fedora-rawhide-x86_64']

Diff of chroots:

+fedora-38-x86_64
+fedora-rawhide-x86_64
+fedora-39-x86_64
+centos-stream-8-x86_64
+centos-stream-9-x86_64
+fedora-37-x86_64
+epel-9-x86_64

Packit was unable to update the settings above as it is missing admin permissions on the @osbuild/cockpit-composer Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the @osbuild/cockpit-composer Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Please sign in to comment.