Replace clap with a simple hand-written arg parser #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clap is too heavyweight for what tiny needs. Replacing it with a simple hand-written parser reduces debug binary sizes a constant 14 MiB (!), and release binary sizes ~400 KiB. - Default build, debug: - Before: 73M - After: 59M - Diff: -14M, -29% - Default build, release: - Before: 6.4M - After: 6.0M - Diff: -0.4M, -6% - Native TLS build, release: - Before: 4.6M - After: 4.2M - Diff: -0.4M, -8% Also saves ~10s build time and ~3s `cargo check` time.
|
🥳 thanks a lot for keeping tiny tiny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clap is too heavyweight for what tiny needs. Replacing it with a simple hand-written parser reduces debug binary sizes a constant 14 MiB (!), and release binary sizes ~400 KiB.
Default build, debug:
Default build, release:
Native TLS build, release:
Also saves ~10s build time and ~3s
cargo checktime.Error messages and the help message is copied from what clap printed and modified.