Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2314 save playlist and regions in screen processor #213

Merged

Conversation

sinejespersen
Copy link
Contributor

@sinejespersen sinejespersen commented Sep 26, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2314

Description

Related to: os2display/display-admin-client#259

  • Set phpdoc_to_comment to falsein .php-cs-fixer.dist.php to avoid breaking psalm ignore
  • Add regions and groups to ScreenInput.php
  • Add "cascade: persist remove" to PlaylistScreenRegion
  • Save playlist/regions in ScreenProcessor.php (as an alternative to sending multiple requests)
  • Save groups in ScreenProcessor.php
  • Update psalm baseline
  • Add regions/playlists and groups to POST screen test
  • composer update symfony/* --with-dependencies

Screenshot of the result

N/A

src/State/ScreenProcessor.php Outdated Show resolved Hide resolved
@sinejespersen sinejespersen force-pushed the feature/2314-save-playlist-and-regions-in-screen-processor branch from f4e4a0f to 2ee824c Compare October 9, 2024 09:05
src/State/ScreenProcessor.php Outdated Show resolved Hide resolved
src/State/ScreenProcessor.php Outdated Show resolved Hide resolved
src/State/ScreenProcessor.php Outdated Show resolved Hide resolved
src/State/ScreenProcessor.php Outdated Show resolved Hide resolved
@sinejespersen sinejespersen requested a review from tuj October 22, 2024 11:31
@sinejespersen sinejespersen merged commit 0d667c7 into develop Oct 23, 2024
13 checks passed
@sinejespersen sinejespersen deleted the feature/2314-save-playlist-and-regions-in-screen-processor branch October 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants