Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist scheduling adjustments #253

Merged
merged 14 commits into from
Aug 15, 2024
Merged

Playlist scheduling adjustments #253

merged 14 commits into from
Aug 15, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Aug 13, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2000

Description

Changes scheduling tool for playlists:

  • Changes duration to an end date to mirror how planning is set up in a calendar.
  • Added interval and count fields.
  • Added "repeat" button for activating repeating events.
  • Added tooltips for each input field in scheduling.
  • Change layout.

Screenshot of the result

Screenshot 2024-08-13 at 12 05 35 Screenshot 2024-08-13 at 12 08 00 Screenshot 2024-08-13 at 12 08 12

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj added the enhancement New feature or request label Aug 13, 2024
@tuj tuj requested a review from sinejespersen August 13, 2024 10:13
@tuj tuj self-assigned this Aug 13, 2024
@tuj tuj marked this pull request as ready for review August 15, 2024 10:54
sinejespersen
sinejespersen previously approved these changes Aug 15, 2024
value: RRule.MINUTELY,
key: "rrule.minutely",
},
// { title: t("schedule.hourly"), value: RRule.HOURLY, key: "rrule.hourly" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REmove?

@@ -61,6 +65,16 @@ function Select({
{label}
{required && " *"}
</label>
{tooltip !== null && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips are typically not accessible for all users.

@tuj tuj merged commit 66f4e45 into develop Aug 15, 2024
4 checks passed
@tuj tuj deleted the feature/rrule-adjustments-v2 branch August 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants