Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted change to rrule dtstart #252

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Reverted change to rrule dtstart #252

merged 2 commits into from
Aug 6, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Aug 6, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2000

Description

  • Reverted change to rrule dtstart in 6576206.
  • Added comments about how rrules are handled.
  • Added helptext explaining that Z is ignored in evaluation of rrules.

Screenshot of the result

Screenshot 2024-08-06 at 12 05 01

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj marked this pull request as ready for review August 6, 2024 10:19
@tuj tuj requested review from turegjorup and sinejespersen August 6, 2024 10:19
@tuj tuj self-assigned this Aug 6, 2024
@tuj tuj added the bug Something isn't working label Aug 6, 2024
@tuj tuj merged commit 4f4654b into develop Aug 6, 2024
4 checks passed
@tuj tuj deleted the feature/rrule-fixes branch August 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinejespersen sinejespersen sinejespersen approved these changes

@turegjorup turegjorup turegjorup approved these changes

Assignees

@tuj tuj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuj @turegjorup @sinejespersen