Feature/1541 update node migrate cra to vite #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinejespersen
commented
May 31, 2024
| environment: | ||
| - NODE_ENV=development | ||
| volumes: | ||
| - .:/app:delegated | ||
| healthcheck: | ||
| test: [ "CMD", "curl", "-f", "http://node:3000/tags" ] |
There was a problem hiding this comment.
http://node:3000/tags has never been a page.
There was a problem hiding this comment.
Then remove healthcheck: as well
tuj
requested changes
May 31, 2024
| environment: | ||
| - NODE_ENV=development | ||
| volumes: | ||
| - .:/app:delegated | ||
| healthcheck: | ||
| test: [ "CMD", "curl", "-f", "http://node:3000/tags" ] |
There was a problem hiding this comment.
Then remove healthcheck: as well
| command: yarn start | ||
| networks: | ||
| - app | ||
| working_dir: /app | ||
| ports: | ||
| - '3000' |
There was a problem hiding this comment.
Will block other from using 0.0.0.0:3000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1541
Description
As it seems CRA is no longer being maintained by fb, I am migrating to Vite.
Screenshot of the result
n/a
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.