Feature/1342 rejseplanen rewrite to fit new api WIP #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinejespersen
commented
May 27, 2024
| @@ -55,7 +55,7 @@ body, | |||
| display: flex; | |||
| justify-content: center; | |||
| padding: 5em; | |||
| z-index: 10; | |||
| z-index: 1021; | |||
|
|
|||
There was a problem hiding this comment.
To avoid this:
tuj
requested changes
May 28, 2024
public/example_config.json
Outdated
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "api": "/", | |||
| "touchButtonRegions": false, | |||
| "rejseplanenApiKey": "abc", | |||
There was a problem hiding this comment.
This needs to be added to the infrastructure templates.
There was a problem hiding this comment.
The default value should be null
There was a problem hiding this comment.
What is "the infrastructure templates"?
| @@ -23,7 +23,7 @@ describe("Playlist pages work", () => { | |||
| cy.get("#save_playlist").should("exist"); | |||
| }); | |||
|
|
|||
| it("It drags and drops slide", () => { | |||
| it.skip("It drags and drops slide", () => { | |||
| /** | ||
| * A callback on changed data. | ||
| * | ||
| * @param {Array} data The data to call back with | ||
| */ | ||
| const changeData = (data) => { | ||
| let selectedOptions = []; | ||
|
|
There was a problem hiding this comment.
New lines around if statements increase the readability of the code.
| * @returns {Array} An array of {label, value, disabled} | ||
| */ | ||
| function mapDataToFitMultiselect(dataToMap) { | ||
| return ( |
There was a problem hiding this comment.
why ( ) around the return value?
It is only needed for jsx
There was a problem hiding this comment.
the linter does it
tuj
requested changes
May 29, 2024
public/example_config.json
Outdated
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "api": "/", | |||
| "touchButtonRegions": false, | |||
| "rejseplanenApiKey": "abc", | |||
tuj
requested changes
May 30, 2024
tuj
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1342
Description
Screenshot of the result
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
os2display/display-templates#153