Skip to content

Commit

Permalink
2321: Changed to only fail on error in github actions
Browse files Browse the repository at this point in the history
  • Loading branch information
tuj committed Nov 21, 2024
1 parent 2bc25b0 commit d9b562c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: |
docker network create frontend
docker compose run --rm node yarn install
docker compose run --rm node yarn check-coding-standards
docker compose run --rm node yarn check-coding-standards-actions
playwright-tests:
name: Playwright
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
- [#264](https://github.com/os2display/display-admin-client/pull/264)
- Added checkbox options component for use in calendar modifiers.
- Fixed multiselect when more than one feed source of the given type is installed.
- Fixed github action to fail on warnings.
- [#268](https://github.com/os2display/display-admin-client/pull/268)
- Added feed source UI.

Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,15 @@
"vite": "^5.2.11"
},
"scripts": {
"lint:js": "eslint --ext .js --ext .jsx ./src --max-warnings=0",
"lint:js": "eslint --ext .js --ext .jsx ./src",
"lint-actions:js": "eslint --ext .js --ext .jsx ./src --max-warnings=0",
"lint:js:fix": "eslint --ext .js --ext .jsx --fix ./src",
"lint:scss": "stylelint \"./src/**/*.scss\" --max-warnings=0",
"lint:scss": "stylelint \"./src/**/*.scss\"",
"lint-actions:scss": "stylelint \"./src/**/*.scss\" --max-warnings=0",
"lint:scss:fix": "stylelint --fix \"./src/**/*.scss\"",
"check-coding-standards": "yarn lint:js && yarn lint:scss",
"apply-coding-standards": "yarn lint:js:fix && yarn lint:scss:fix",
"check-coding-standards-actions": "yarn lint-actions:js && yarn lint-actions:scss",
"start": "vite --host 0.0.0.0",
"build": "vite build",
"preview": "vite preview"
Expand Down

0 comments on commit d9b562c

Please sign in to comment.