Introduce a configuration that points a public endpoint for the search-host #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… host. The search-host is accessed both by the admin-backend, and directly by the administrative-users browser. For situations where the public url for the search-host is not accessible to the backend (eg. due to firewalls) we need two seperate configurations for the public url (for the users browser) and the internal url (for backend interaction).
danquah
pushed a commit
to reload/os2display-admin
that referenced
this pull request
May 28, 2019
Add YouTube and Vimeo bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search-host is accessed both by the admin-backend, and directly by the
administrative-users browser. For situations where the public url for
the search-host is not accessible to the backend (eg. due to firewalls) we need
two seperate configurations for the public url (for the users browser) and the
internal url (for backend interaction).
Notice: even tough additions to parameters.yml.dist should lead to the parameters.yml being updated automatically at next deploy, this does not seem to happen.
In other words, prior to deploying this change to an existing environment you have to
introduce the parameter manually into parameters.yml. (I might also just be wrong, but
this has been my experience so far).