Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP virt_autotest: Set up the 2 new purchased machines in OSD as ipmi worker #20613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP virt_autotest: Set up the 2 new purchased machines in OSD as ipmi worker #20613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ipmi_backend_utils.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,9 @@ sub set_grub_on_vh {
#ipmitool to perform server management
sub ipmitool {
my ($cmd) = @_;
my $ipmi_options = $bmwqemu::vars{IPMI_OPTIONS} // '-I lanplus';

my @cmd = ('ipmitool', '-I', 'lanplus', '-H', $bmwqemu::vars{IPMI_HOSTNAME}, '-U', $bmwqemu::vars{IPMI_USER}, '-P', $bmwqemu::vars{IPMI_PASSWORD});
my @cmd = ('ipmitool', split(' ', $ipmi_options), '-H', $bmwqemu::vars{IPMI_HOSTNAME}, '-U', $bmwqemu::vars{IPMI_USER}, '-P', $bmwqemu::vars{IPMI_PASSWORD});
push(@cmd, split(/ /, $cmd));
Comment on lines 359 to 364
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that would fix the one specific issue. But I strongly suggest to not replicate this code from os-autoinst but rather use the functions from there directly and as required extend the backend.


my ($stdin, $stdout, $stderr, $ret);
Expand Down
Loading