Catch JSON decoding errors in browser.get #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
reviewed
Oct 11, 2021
kalikiana
force-pushed
the
browser_get_json_decode
branch
from
c494844
to
483752e
Compare
perlpunk
approved these changes
Oct 11, 2021
okurz
requested changes
Oct 11, 2021
kalikiana
force-pushed
the
browser_get_json_decode
branch
from
483752e
to
8d0ed2a
Compare
okurz
previously requested changes
Oct 11, 2021
|
Any progress on this? The pipeline fails everytime, so we don't have a review for o3 curently. |
Sorry, I was having some problems running unit tests locally, and the docs didn't help me remember how to run them (proposed #183 to try and improve it a little). I have a test, but it's not raising the exception yet. |
kalikiana
force-pushed
the
browser_get_json_decode
branch
3 times, most recently
from
014a9ae
to
3689d01
Compare
okurz
reviewed
Oct 14, 2021
kalikiana
force-pushed
the
browser_get_json_decode
branch
4 times, most recently
from
5397234
to
702850c
Compare
okurz
reviewed
Oct 22, 2021
kalikiana
force-pushed
the
browser_get_json_decode
branch
from
702850c
to
06347c0
Compare
Martchus
reviewed
Oct 22, 2021
kalikiana
force-pushed
the
browser_get_json_decode
branch
from
06347c0
to
be7fe50
Compare
Martchus
approved these changes
Oct 25, 2021
kalikiana
dismissed
okurz’s stale review
Comments have been addressed, and there's 2 other positive reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://progress.opensuse.org/issues/100709