feat(proxy): flag to keep forwarded headers #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
force-pushed
the
forwarded-headers
branch
from
0509ea9
to
ce3e818
Compare
aeneasr
changed the title
aeneasr
commented
Jul 18, 2023
| c.setScheme(r) | ||
| c.setHost(r) | ||
|
|
||
| *r.Out = *r.Out.WithContext(context.WithValue(ctx, hostConfigKey, c)) |
There was a problem hiding this comment.
This is already done by getHostConfig
| if err != nil { | ||
| o.onReqError(r.Out, err) | ||
| return | ||
| } | ||
|
|
||
| if c.TrustForwardedHeaders { | ||
| headers := []string{ |
There was a problem hiding this comment.
This fixes the regression
Comment on lines
+20
to
+21
| ReqMiddleware func(req *httputil.ProxyRequest, config *HostConfig, body []byte) ([]byte, error) | ||
| HostMapper func(ctx context.Context, r *http.Request) (context.Context, *HostConfig, error) |
There was a problem hiding this comment.
It's no longer possible to use the context properly because we don't know whether we get the context from req.In or req.Out now. So context needs to be explicit now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag to revert regressions introduced by switching to proxy.Rewrite.