chore: deprecate unused configx option

ory · Sep 18, 2024 · 3d815ba · 3d815ba
1 parent f03cb99
commit 3d815ba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/configx/options.go b/configx/options.go
@@ -102,10 +102,9 @@ func WithUserProviders(providers ...koanf.Provider) OptionModifier {
  }
 }
 
+// DEPRECATED without replacement. This option is a no-op.
 func OmitKeysFromTracing(keys ...string) OptionModifier {
- return func(p *Provider) {
- p.excludeFieldsFromTracing = keys
- }
+ return func(*Provider) {}
 }
 
 func AttachWatcher(watcher func(event watcherx.Event, err error)) OptionModifier {

diff --git a/configx/provider.go b/configx/provider.go
@@ -41,12 +41,11 @@ type Provider struct {
  *koanf.Koanf
  immutables, exceptImmutables []string
 
- schema []byte
- flags *pflag.FlagSet
- validator *jsonschema.Schema
- onChanges []func(watcherx.Event, error)
- onValidationError func(k *koanf.Koanf, err error)
- excludeFieldsFromTracing []string
+ schema []byte
+ flags *pflag.FlagSet
+ validator *jsonschema.Schema
+ onChanges []func(watcherx.Event, error)
+ onValidationError func(k *koanf.Koanf, err error)
 
  forcedValues []tuple
  baseValues []tuple
@@ -91,12 +90,11 @@ func New(ctx context.Context, schema []byte, modifiers ...OptionModifier) (*Prov
  l.Out = io.Discard
 
  p := &Provider{
- schema: schema,
- validator: validator,
- onValidationError: func(k *koanf.Koanf, err error) {},
- excludeFieldsFromTracing: []string{"dsn", "secret", "password", "key"},
- logger: logrusx.New("discarding config logger", "", logrusx.UseLogger(l)),
- Koanf: koanf.NewWithConf(koanf.Conf{Delim: Delimiter, StrictMerge: true}),
+ schema: schema,
+ validator: validator,
+ onValidationError: func(k *koanf.Koanf, err error) {},
+ logger: logrusx.New("discarding config logger", "", logrusx.UseLogger(l)),
+ Koanf: koanf.NewWithConf(koanf.Conf{Delim: Delimiter, StrictMerge: true}),
  }
 
  for _, m := range modifiers {