fix: removes duplicate root manifest loading when loading collections

Signed-off-by: Jennifer Power <[email protected]>
ortelius · Oct 19, 2022 · baef487 · baef487
1 parent a9f24cc
commit baef487
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/registryclient/orasclient/oras.go b/registryclient/orasclient/oras.go
@@ -422,7 +422,7 @@ func getDefaultMediaType(file string) (string, error) {
 
 // loadCollection is a helper function that allows a collection to be loaded with a given repository.
 func loadCollection(ctx context.Context, repo registry.Repository, reference string) (collection.Collection, error) {
-	desc, _, err := repo.FetchReference(ctx, reference)
+	desc, err := repo.Resolve(ctx, reference)
 	if err != nil {
 		return collection.Collection{}, err
 	}

diff --git a/registryclient/orasclient/oras_test.go b/registryclient/orasclient/oras_test.go
@@ -313,7 +313,7 @@ func TestPushPull(t *testing.T) {
 		c, err := NewClient(WithPlainHTTP(true))
 		require.NoError(t, err)
 		_, _, err = c.Pull(context.TODO(), notExistRef, memory.New())
-		require.EqualError(t, err, fmt.Sprintf("%s: not found", notExistTag))
+		require.EqualError(t, err, fmt.Sprintf("%s: not found", notExistRef))
 		require.NoError(t, c.Destroy())
 	})
 }