Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warnings instead of throwing exceptions for missing params while filling out the VersionInfo defaults #216

Merged

Conversation

koksyn
Copy link
Contributor

@koksyn koksyn commented Jan 13, 2023

Version notes 2.3.1

  • logs only warnings instead of throwing exception, when cannot fulfill default values for <VersionInfo>
    (no configuration data required by the formula), see Issue #213. All missing fields will be fulfilled by dummy values like on the list:
    project.version: 1.0.0
    project.organization.name: Default organization
    project.inceptionYear: 2020
    project.name: Java Project
    project.artifactId: java-project
    project.description: A Java project.
    outfile: app.exe

Closes #213

Copy link
Collaborator

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Looks good to me :)

@lukaszlenart
Copy link
Collaborator

@koksyn do you plan additional work on this PR?

@koksyn
Copy link
Contributor Author

koksyn commented Jan 16, 2023

@koksyn do you plan additional work on this PR?

Only one change regarding buildYear inside one Unit test (to make it deterministic).

@koksyn koksyn marked this pull request as ready for review January 16, 2023 10:54
@koksyn koksyn changed the title Draft: Log warnings instead of throwing exceptions for missing params while filling out the VersionInfo defaults Log warnings instead of throwing exceptions for missing params while filling out the VersionInfo defaults Jan 16, 2023
@lukaszlenart lukaszlenart merged commit c475294 into orphan-oss:master Jan 17, 2023
@koksyn koksyn deleted the feature-warn-not-throw-defaults branch January 17, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when project.description is not defined
2 participants