Migrate to aws sdk go v2

[johannesvietze]

fixes #1030

[orlangure]

Hey @johannesvietze, thank you for working on this!
The build fails, there is a number of linter warnings to take care of, as well as localstack tests that require attention.
Will you be able to fix all that, or should I take over?

[johannesvietze]

I'm on vacation for two weeks. If there's no hurry, I can have a look after. Otherwise, feel free to take over.

[johannesvietze]

Hi @orlangure,

I found some time to fix the test. Could you please check the 4 open TODOs (they are all related to the same thing...)?

The aws-sdk-go-v2 migration added a leading slash to some prefixes...

[orlangure]

Hey @johannesvietze, I see that TODO comments are only in the test code, so it shouldn't affect the users. The users are free to use whichever aws sdk version they like. The changes behind these comments look good to me.

[johannesvietze]

Hey @johannesvietze, I see that TODO comments are only in the test code, so it shouldn't affect the users. The users are free to use whichever aws sdk version they like. The changes behind these comments look good to me.

sounds good, I have removed the TODOs

[codecov]

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (97f7ed9) to head (bedfa9d).
Report is 34 commits behind head on master.

Files	Patch %	Lines
preset/localstack/options_s3.go	89.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
- Coverage   85.87%   77.08%   -8.79%     
==========================================
  Files          50       55       +5     
  Lines        2350     2623     +273     
==========================================
+ Hits         2018     2022       +4     
- Misses        173      443     +270     
+ Partials      159      158       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannesvietze]

hey @orlangure could you have a look? not sure why the linter fails...