Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With this fixes sqlite should work with new nodes. #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

With this fixes sqlite should work with new nodes. #36

wants to merge 5 commits into from

Conversation

rbochenski
Copy link

Fixing sources to work with nodes 0.6.x
I have added extends module. Perhaps it should be done in different way.

rbochenski added 2 commits November 8, 2011 14:05
Nodejs 0.6.x
ccc2c08 
Fixing sources to work with nodes 0.6.x
Fixing possible coredump.
e01b1e1
@rbochenski
Copy link
Author

This two commits should be merged to work properly.

@ndaversa
Copy link

ndaversa commented Dec 4, 2011

@rbochenski

Error: Cannot find module './sqlite3_bindings'
at Function._resolveFilename (module.js:334:11)
at Function._load (module.js:279:25)
at Module.require (module.js:357:17)
at require (module.js:368:17)
at Object. (/Users/ndaversa/sample/node_modules/sqlite/sqlite.js:19:14)
at Module._compile (module.js:432:26)
at Object..js (module.js:450:10)
at Module.load (module.js:351:31)
at Function._load (module.js:310:12)
at Module.require (module.js:357:17)

@rbochenski
Copy link
Author

Just link build/Release/sqlite3_bindings.node into sqlite3_bindings sqlite dir.
I am not sure how to do it properly during compilation/installation.

jimmybergman and others added 3 commits February 2, 2012 11:34
@jimmybergman
Make it work after npm install without warning.
675d965 
* Add deps/mpool-2.1.0 build output to .gitignore
* Remove unused reference to deprecated sys module
* Create sqlite3_bindings symlink in build
@jimmybergman
Fix .gitignore so that it only ignores build output in mpool dependency
d14ef66
Merge pull request #1 from jimmybergman/master
4976bdd 
Add the required symlink during the build
@panzi
Copy link

panzi commented Jun 5, 2012

I fixed the "Cannot find module './sqlite3_bindings'" error differently: https://github.com/panzi/node-sqlite/commit/f6791b9e9c2418fc43f9b9e76ace1e6a39c11d8a
No idea if this is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbochenski @ndaversa @panzi @jimmybergman