Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on Mac OS X, which ships with an older version of sqlite. Because the include in the node-sqlite file src/database.h is global the older version was being pulled in, causing the following error:
So this branch contains a change to database.h so the include is relative, using the path to sqlite.h under deps.
Also, I noticed that the sqlite dependency is older than 3.7.5 and the sqlite folks recommend upgrading to 3.7.5 and I couldn't tell which version of sqlite was there, except that it wasn't the same as 3.7.5, so I updated the sqlite files and renamed sqlite to show which version was current. To reflect this I also updated the paths in wscript to use a SQLITE variable that points to the sqlite sub-dir of deps.
Please feel free to contact me via Skype (Bill.Barnhill), or email (w.a.barnhill@gmail).