Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & fix sweeper #50

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

meggarr
Copy link
Contributor

@meggarr meggarr commented Dec 19, 2023

  • Refactor the sweeper by using SB Scheduler
  • Move configs under conductor.orkes
  • Add back recordQueueDepth from WorkflowReconciler

Fixes #47

@meggarr
Copy link
Contributor Author

meggarr commented Dec 19, 2023

@v1r3n @manan164 , can you pls help review ?

@meggarr
Copy link
Contributor Author

meggarr commented Dec 20, 2023

@v1r3n @manan164, & Can you pls help check the Gradle build check under CI ? (I don't think it relates to this PR.)

Run docker/login-action@v1
with:
ecr: auto
logout: true
Warning: The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Error: Username and password required

@meggarr
Copy link
Contributor Author

meggarr commented Dec 22, 2023

Integrated lock changes in #49

@meggarr meggarr mentioned this pull request Dec 22, 2023
@meggarr
Copy link
Contributor Author

meggarr commented Dec 28, 2023

Hi, & can this be reviewed ?

@meggarr
Copy link
Contributor Author

meggarr commented Dec 29, 2023

@v1r3n Can you please help with the "CI / Gradle Build" ? It seems missing the username/password, which I don't have one. :(

@meggarr meggarr requested a review from manan164 January 2, 2024 01:51
@rajeshwar-nu
Copy link

@manan164 @v1r3n Requesting quick resolution on this one 🙏🏻

@meggarr meggarr requested a review from manan164 January 11, 2024 11:41
@manan164 manan164 merged commit 004d605 into orkes-io:main Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High redis usage caused by OrkesWorkflowSweeper
3 participants