Fix per review

orkes-io · Jan 2, 2024 · fa0c5b5 · fa0c5b5
1 parent 29d7a58
commit fa0c5b5
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/server/src/main/java/io/orkes/conductor/server/service/OrkesWorkflowSweepWorker.java b/server/src/main/java/io/orkes/conductor/server/service/OrkesWorkflowSweepWorker.java
@@ -90,8 +90,11 @@ private void sweep(String workflowId) {
             // 1. Run decide on the workflow
             WorkflowModel workflow = executionDAO.getWorkflow(workflowId, true);
             if (workflow == null) {
-                throw new NotFoundException(
-                        String.format("Workflow NOT found by id: %s", workflowId));
+                log.warn(
+                        "Workflow NOT found by id: {}. Removed it from decider queue safely.",
+                        workflowId);
+                queueDAO.remove(DECIDER_QUEUE, workflowId);
+                return;
             }
             workflow = decideAndRemove(workflow);
             if (workflow == null || workflow.getStatus().isTerminal()) {