Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vertex, TaxJar, Avalara #59
Add Vertex, TaxJar, Avalara #59
Changes from 28 commits
f9d0f92
e0a6b18
bfd45b6
281ce1f
591f0f6
f987d94
2eddce5
6fa6de2
cc92cb6
3ea532d
405fb34
40d4e49
551254a
0ad08c7
ae2d96b
25a89df
0f14441
0bf6eec
81db3b9
432abdf
4e4e713
266bde9
6263c51
553d5a1
03c56a6
ae11694
df73caa
bbd8aa4
995b14c
1848632
d214766
15e7509
56023ea
0567b83
080dd6d
eaae6f5
b07c270
7f53c36
4b1ada0
59bf246
aa73883
094d5cf
4146a6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of avoiding using the
var
? Because it's not clear for reviewers which type is it and decreases the speed of reading and understanding the code. The IEnumerable gives more information in this case :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
var
is a pattern that's pretty engrained in me from all the C# projects at four51. I do see how it makes reviewing code hard if you're not viewing in the VS editor (where hovering shows you the type).I'm willing to consider this. It would be a rather large code change throughout the project. Do you know what the OC platform code does? That's often what we model these other tools on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal opinion is to use it only if the type can't be easily inferred by its context/usage. Adds a lot of clutter which in my opinion actually makes it harder to read (more mental load) and is unnecessarily verbose in many situations
ie:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why do we have the public properties which start with a lower case? Do we have a code notation standard for the OC Catalyst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are lowercase because when they are serialized to JSON they need to be lower case to match the property names the Vertex API is expecting.
We don't have a code notation standard for the OC Catalyst - I can create an issue for that. If you want to work on it that would be awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really cared, we could use JsonProperty to determine how something is serialized. For example
But it seems like an abstraction just for the sake of abstraction. I personally like that the property names match exactly what the vertex properties are.