OCP-1082: Category List View, OCP-1055: [WIP] Order Confirmation Page, OCP-1043: Breadcrumbs, OCP-1050: show SalePrice in Product Detail #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erincdustin
reviewed
Sep 12, 2024
|
|
||
| return partials.map((partial, index) => { | ||
| const partialPath = `/${partials.slice(0, index + 1).join("/")}${ | ||
| partial === "orders" ? "/incoming" : "" |
There was a problem hiding this comment.
A few comments on breadcrumbs:
- we can get rid of the order direction logic from admin here
- can we format category names to display a little nicer? (e.g. dog-beds --> Dog Beds)
- We'll have to rethink either the routing conventions or the breadcrumb solution because the Shop and {category} breadcrumbs are routing to 404 pages
There was a problem hiding this comment.
how about Shop routes to /products and {catalog} routes to /shop/{catalog}/products?
probably best done by refactoring our routes.tsx to use the "official" breadcrumb solution?
https://reactrouter.com/en/main/hooks/use-matches#breadcrumbs
upgrade to latest, use recommended solution for breadcrumbs: https://reactrouter.com/en/main/hooks/use-matches#breadcrumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCP-1082: Category Accordion View
OCP-1055: [WIP] Order Confirmation Page
OCP-1043: Breadcrumbs
OCP-1050: show SalePrice in Product Detail and Product Card