Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/translation ja #2681

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Conversation

shibomb
Copy link
Contributor

@shibomb shibomb commented Jul 24, 2023

Add: Japanese Translation file.

@tabuna
Copy link
Member

tabuna commented Jul 24, 2023

Hi @shibomb! Unfortunately, the tests to identify redundant transfers did fail.
For instance, there is a phrase that will never be used: 'Add child'.

@shibomb
Copy link
Contributor Author

shibomb commented Jul 24, 2023

@tabuna
Thank you for pointing this out!

I ran grep and extracted the "_(" string from all sources. The tests directory was also included at that time.

I ran a unit test on my github and found the following two NGs.
"Add child", "Added Item".
I deleted them.

Please review again!
Best regards.

@tabuna tabuna merged commit ebbd5e9 into orchidsoftware:master Jul 24, 2023
9 checks passed
@shibomb
Copy link
Contributor Author

shibomb commented Jul 24, 2023

Thank you for your time.

@shibomb shibomb deleted the feature/translation_ja branch July 24, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants