WIP: Add support for ImGui #550
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the scenario to prevent calling oapiOpenDialog before it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Dear ImGui, which provides an OS agnostic GUI toolkit.
The first commit hooks the library to the orbiter core and the D3D9Client library. I've used cmake fetch+patch mecanism to add the external dependency. I'm not an expert in cmake so don't hesitate to comment if you're not satisfied with the way the library has been added.
The ImGui code is instanciated inside the Orbitersdk.lib file so that modules can eventually use it in the future.
The second commit changes the handling of input boxes/context menus to use the new library.
Some feedback would be nice from users with high DPI monitors so that we can know if the font size is acceptable.
The library has backends for DX9/DX12, OpenGL, vulkan, WinAPI, SDL, glfw... so it should be future proof.
I've got ImGui equivalents for almost all dialogs in my linux branch so if we decide to expand on this, it should not be too difficult to replace the core Orbiter dialogs currently using the Windows API.