Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GSE cryo dewars, remove cabin heater boilers from cabin fans #1305

Open
wants to merge 2 commits into
base: Orbiter2016
Choose a base branch
from
Open

Implement GSE cryo dewars, remove cabin heater boilers from cabin fans #1305

wants to merge 2 commits into from

Conversation

rcflyinghokie
Copy link
Collaborator

No description provided.

@rcflyinghokie rcflyinghokie marked this pull request as ready for review October 16, 2024 16:23
@rcflyinghokie
Copy link
Collaborator Author

Only issue is since the old config has the valves open, loading new scenarios will cause cryo pressure drops. IN valves need to be manually closed in the scn unless code can be added to check this.

ThatRedMelon
ThatRedMelon approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@ThatRedMelon ThatRedMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I can tell, the cryo systems remained stable throughout countdown up until liftoff. Comparing scenarios before and after T-2:15, the IN valve closes correctly and systems still remain stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatRedMelon ThatRedMelon ThatRedMelon approved these changes

@n7275 n7275 Awaiting requested review from n7275

@maxq519 maxq519 Awaiting requested review from maxq519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcflyinghokie @ThatRedMelon