This repository has been archived by the owner on Mar 2, 2021. It is now read-only.
Fix the management of external SLD styles #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I perform more accurate tests to define if an input request is valid ot not. I also fix two potential NPEs introduced while reworking the code. Finally, I fix the sample SLD as it is not valid.
ebocher
pushed a commit
that referenced
this pull request
Jul 5, 2013
Fix the management of external SLD styles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an important change that authorizes back the use of external SLD files in the wms server, as described in #14. Unit tests have been added to check that:
@ebocher proposed some code to improve Exceptions management. I kept it as I think it is a good idea.