fix: check content-type when using referrers API #635
Conversation
ktarplee
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
|
@Wwwsylvia @shizhMSFT This is ready from my perspective. Once you review the PR I can rebase if desired. |
ktarplee
force-pushed
the
633-referrers-content-type
branch
2 times, most recently
from
ffed3d8 to
fc50894
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 75.20% 75.23% +0.03%
==========================================
Files 59 59
Lines 5473 5480 +7
==========================================
+ Hits 4116 4123 +7
Misses 1001 1001
Partials 356 356 ☔ View full report in Codecov by Sentry. |
|
@shizhMSFT Can we get this merged? |
|
Just back from some other work, sorry for the delay! I'm reviewing it. |
|
@Wwwsylvia I liked you changes. I tested them and it still resolves the original issue. Let me know if there are any other changes or if you want me to squash the commits. |
Return an ErrUnsupported to when the referrers API is not supported. Signed-off-by: Kyle M. Tarplee <[email protected]>
ktarplee
force-pushed
the
633-referrers-content-type
branch
from
fd92b01 to
c14305f
Compare
|
@Wwwsylvia @shizhMSFT This is rebased and should be ready to be merged. |
When accessing the referrer's API, this adds a check to make sure the content-type is an OCI index.
Also fixes the tests to properly set the content-type header in the response.
Closes #633