Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point out that PR needs to remove GraalVM reachability metadata related to MBeans #135

Closed
wants to merge 1 commit into from
Closed

Point out that PR needs to remove GraalVM reachability metadata related to MBeans #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,22 @@ output if necessary:
./gradlew check
```

All submitted GraalVM reachability metadata, if the MBean-related part is unnecessary, should actively remove the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the root cause in Native Image. Could you be more precise about what is failing if we introduce MBean metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraalVM reachability metadata related to the MBean. These metadata can cause calls to
`ManagementFactory.getPlatformMBeanServer()` to fail with `javax.management.openmbean.OpenDataException`. In most cases,
it would appear that the metadata is sufficient for the bootstrapping of the MBean server to take a different code path
to normal and this path fails. There are reference operations in some PRs, such
as https://github.com/oracle/graalvm-reachability-metadata/pull/113, https://github.com/oracle/graalvm-reachability-metadata/pull/161,
https://github.com/oracle/graalvm-reachability-metadata/pull/162. This includes the following five packages.

```
java.lang.management.**
jdk.management.**
com.sun.management.**
sun.management.**
javax.management.**
```

### Tests

Every submitted library must feature tests that serve as a safeguard against regressions.
Expand Down