Skip to content

Commit

Permalink
Point out that PR needs to remove GraalVM reachability metadata relat…
Browse files Browse the repository at this point in the history
…ed to MBeans
  • Loading branch information
linghengqian committed Jan 21, 2023
1 parent bef8424 commit 32dfdd0
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,22 @@ output if necessary:
./gradlew check
```

All submitted GraalVM reachability metadata, if the MBean-related part is unnecessary, should actively remove the
GraalVM reachability metadata related to the MBean. These metadata can cause calls to
`ManagementFactory.getPlatformMBeanServer()` to fail with `javax.management.openmbean.OpenDataException`. In most cases,
it would appear that the metadata is sufficient for the bootstrapping of the MBean server to take a different code path
to normal and this path fails. There are reference operations in some PRs, such
as https://github.com/oracle/graalvm-reachability-metadata/pull/113, https://github.com/oracle/graalvm-reachability-metadata/pull/161,
https://github.com/oracle/graalvm-reachability-metadata/pull/162. This includes the following five packages.

```
java.lang.management.**
jdk.management.**
com.sun.management.**
sun.management.**
javax.management.**
```

### Tests

Every submitted library must feature tests that serve as a safeguard against regressions.
Expand Down

0 comments on commit 32dfdd0

Please sign in to comment.