-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pymongo.patch for more pymongo versions #449
base: master
Are you sure you want to change the base?
Conversation
(tested on 4.3.3, 4.10.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, I'll look into merging it shortly.
I'm still not quite clear for sereral things.
|
I know question 3 can be resolved by manually modify files generated at /target/classes/org.graalvm.python.vfs/home/lib-graalpython/patches, then clean pip-graal wheel caches, then rebuild. |
for question 2 I tried, but seems 4.8.0 cannot cover 4.10.1. maybe we have to suffer the patch failing error warning(though it can work) |
…chenism here. This reverts commit 24abdfe.
Yes, splitting the versions would be better. The patches are not applied by the filename, but there's a metadata file with rules that determines what package version should be patched with which patch and the version can be a range. There is a README explaining the metadata format. The existing entry for As for getting it into existing released jar, unfortunately there is no nice mechanism in the current release without repacking the jar manually. I think it's simpler to build the wheel outside of maven with |
Hi @XenoAmess, do you want to work on splitting the versions or should I merge it as it is? |
merge it and when weekend I would find some time to start another pr for the version range. |
(tested on 4.3.3, 4.10.1)
reason: