Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODSC-49565/corrections in metrics calculation per horizon #415

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

govarsha
Copy link
Contributor

@govarsha govarsha commented Nov 7, 2023

https://jira.oci.oraclecorp.com/browse/ODSC-49565

  1. When test data has more values than horizon, operator fails.
  2. When there is a horizon value missing for all series in test data, then test dataframe wont have that horizon. In the present code, that missing horizon is not removed from outputs so there is mismatch in the metrics calculation per horizon i.e; mismatch in the horizon picked from outputs and test data.
    Changes:
    outputs and test data frames should have same dates. So remove the extra dates that are not present in both test data & outputs and ensure that the dates are sorted in both dataframes so that there is no mismatch in metrics calculation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 7, 2023
@govarsha govarsha changed the title changes for ODSC-49565 ODSC-49565/corrections in metrics calculation per horizon Nov 7, 2023
@govarsha govarsha self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

📌 Cov diff with main:

Coverage-2%

📌 Overall coverage:

Coverage-28.43%

@ahosler ahosler merged commit 3200c2c into feature/forecasting Nov 7, 2023
8 of 12 checks passed
Copy link
Member

@ahosler ahosler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants