Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ads.set_auth() to use both customized config and signer #371

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Update ads.set_auth() to use both customized config and signer #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd28516
Update ads.set_auth() to use both customized config and signer when p…
qiuosier Oct 10, 2023
b44c0a1
Merge commit 'a4a3d9a16e0bccd9cac5eb6fddb813c30f3b2669'
qiuosier Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ads/common/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ def create_signer(
>>> auth = ads.auth.create_signer(auth_type="security_token", config=config) # security token authentication created based on provided config
"""
if signer or signer_callable:
configuration = ads.telemetry.update_oci_client_config()
configuration = ads.telemetry.update_oci_client_config(config)
if signer_callable:
signer = signer_callable(**signer_kwargs)
signer_dict = {
Expand Down Expand Up @@ -479,7 +479,7 @@ def default_signer(client_kwargs: Optional[Dict] = None) -> Dict:
"""
auth_state = AuthState()
if auth_state.oci_signer or auth_state.oci_signer_callable:
configuration = ads.telemetry.update_oci_client_config()
configuration = ads.telemetry.update_oci_client_config(auth_state.oci_config)
signer = auth_state.oci_signer
if auth_state.oci_signer_callable:
signer_kwargs = auth_state.oci_signer_kwargs or {}
Expand Down