Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming dataframe support #354

Conversation

yogesh266
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 27, 2023
@KshitizLohia KshitizLohia changed the base branch from feature/featurestore/1.0.3 to feature/feature-store-1.0.4 September 27, 2023 09:05
@KshitizLohia
Copy link
Member

KshitizLohia commented Sep 29, 2023

This is a nice change. Great that you are iterating on the functionality and handling everything with saavy 💯 . Also, Checklist we need to undergo to release streaming dataframe support

  • Integration tests with timeout functionality
  • Integration tests on how schema evolution can happen in streaming dataframe
  • Unit tests for streaming dataframe materialise operation
  • Addition of sample notebooks for showcasing streaming dataframe support in conda pack
  • Update the documentation for streaming dataframe support

Addition of more test cases could further increase the time it takes to run canary. We might need to see how to run integration tests with streaming support or to have a seperate integration test pipeline for streaming dataframe support.

@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-61.79%

@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-61.79%

@KshitizLohia KshitizLohia changed the title [WIP] DO_NOT_MERGE-Odsc 47451 streaming dataframe support Streaming dataframe support Oct 16, 2023
@@ -0,0 +1,185 @@
import time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-61.79%

@KshitizLohia KshitizLohia merged commit fbdddd3 into feature/feature-store-1.0.4 Oct 16, 2023
11 of 12 checks passed
harsh97 pushed a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants