Feature/aqua ms changes 2 #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasray0208
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
1 similar comment
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
…feature/aqua_ms_changes_2
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
previously approved these changes
Jan 10, 2025
| super().__init__( | ||
| f"The model {model_ocid} does not contain the metadata with key {metadata_key}." | ||
| ) | ||
| pass |
There was a problem hiding this comment.
redundant noop statement
vikasray0208
dismissed
VipulMascarenhas’s stale review
The merge-base changed after approval.
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Jan 11, 2025
VipulMascarenhas
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is for adding/updating API for listing SMM ,Model custom and defined metadata artifact in DataScienceModel in ADS.
This PR will enable following changes
API Spec :- https://confluence.oci.oraclecorp.com/pages/viewpage.action?spaceKey=ODSC&title=API+changes+for+Model+store+for+Aqua
Design Doc :- https://confluence.oci.oraclecorp.com/display/ODSC/Model+Store+Enhancements+For+AQUA+-+Design
Duplicate of #1019