Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate JobId as UUIDv7 #58

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat: Generate JobId as UUIDv7 #58

merged 2 commits into from
Nov 14, 2024

Conversation

katsujukou
Copy link
Contributor

📃 Ticket

✍ Description

The underlying representation of Job Id is changed to the string of the UUIDv7 form.
This PR brings no breaking changes.

📸 Test Result

Please see the GitHub Actions' result.

🔗 Related PRs

@orangekame3 orangekame3 changed the title Generate JobId as UUIDv7 feat: Generate JobId as UUIDv7 Nov 14, 2024
@orangekame3
Copy link
Collaborator

@katsujukou
Thank you. Please follow the Conventional Commit below from next time!

https://oqtopus-cloud.readthedocs.io/latest/developer_guidelines/#conventional-commits

Copy link
Collaborator

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM🐱

Copy link
Contributor

@shgokita shgokita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shgokita shgokita merged commit 7c6ea76 into develop Nov 14, 2024
7 checks passed
@shgokita shgokita deleted the issue#57/uuidv7 branch November 14, 2024 05:37
@orangekame3 orangekame3 added the feature Adding a new feature label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants