Recover when syslog-ng is restarted #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syslog-ng restart, the socket on disk is removed and a new one is created. On the riemann-tool side, this result in an EPIPE exception being raised. When this happen, initiate a new connection and retry the operation. If the socket is not available at startup, we should not terminate execution, so rework the socket initialization logic so that it happens "when needed" rather that "on startup". Any ECONNREFUSED or EACCES exception will be output to stderr but execution will continue.
This was referenced Jan 11, 2024
Merged
jpcweb
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syslog-ng restart, the socket on disk is removed and a new one is
created. On the riemann-tool side, this result in an EPIPE exception
being raised.
When this happen, initiate a new connection and retry the operation.
If the socket is not available at startup, we should not terminate
execution, so rework the socket initialization logic so that it happens
"when needed" rather that "on startup". Any ECONNREFUSED or EACCES
exception will be output to stderr but execution will continue.