Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order summary component #145

Open
wants to merge 8 commits into
base: order_summary_component
Choose a base branch
from
Open

Order summary component #145

wants to merge 8 commits into from

Conversation

ngumokenneth
Copy link

order_summary_component-desktop
order_summary_component-mobile

almirsarajcic
almirsarajcic requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location of the image files is wrong and looks completely different than the design.

almirsarajcic
almirsarajcic requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design can still be improved, but also the file structure is incorrect. Please take a look at solutions from other developers (other PRs in this repo to see how it should look like).

This is how it looks like in your PR:
image

And this is how it should look like:
image

@ngumokenneth
Copy link
Author

sure I'll look into it. Thanks.

almirsarajcic
almirsarajcic requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI needs to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic