[FSSDK-10763] Implement UPS request batching for decideForKeys #440

FarhanAnjum-opti · 2024-11-13T15:51:51Z

Summary

Currently, decideForKeys loops over the list of flags and calls decide for each, which in turn calls ups. So for decideForKeys, there is two calls per flag to UPS. This PR batches UPS calls when using decideForKeys.

Test plan

Existing tests are updated to work with the new change. New tests will be added for batching.

Issues

FSSDK-10763

…e_for_keys

…file` in decision logic. 🛠️ optimizely/user_profile.py -> Improved user profile loading with missing key checks. 🛠️ tests/test_decision_service.py -> Updated tests to include user profile tracker.

🛠️ tests/test_decision_service.py -> Updated experiment bucket map call. 🛠️ tests/test_decision_service.py -> Introduced user_profile_tracker usage. 🛠️ tests/test_decision_service.py -> Modified method calls with user_profile_tracker.

tests/test_decision_service.py -> Added user profile tracker object

tests/test_decision_service.py -> Fixed tests

Mat001

Looks great! Just please cleanup old commented out pieces. Then we'll merge once done :)

optimizely/decision_service.py

optimizely/optimizely.py

optimizely/user_profile.py

tests/test_user_context.py

optimizely/decision_service.py

optimizely/optimizely.py

optimizely/optimizely.py -> Added loading and saving profile logic

optimizely/user_profile.py -> Testing user profile update logic

optimizely/user_profile.py -> Removed unused import statement

optimizely/user_profile.py -> Fixed handling of reasons list optimizely/user_profile.py -> Improved profile retrieval error logging tests/test_decision_service.py -> Updated mock checks to simplify tests tests/test_user_profile.py -> Added tests for user profile handling tests/test_optimizely.py -> New test for variation lookup and save

… logic.

FarhanAnjum-opti added 14 commits November 4, 2024 22:45

update: UserProfile class created, changes in decision_service, decid…

0411458

…e_for_keys

update: get_variation function changed

43a0c74

update: new function in decision_service

d462339

update: everything implemented from java. tests are failing

fc976ff

update: minor changes

4187366

update: user_profile_tracker added to tests

8d32180

update: some tests fixed

ba44a6c

🛠️ optimizely/decision_service.py -> Added check for `ignore_user_pro…

c78df2f

…file` in decision logic. 🛠️ optimizely/user_profile.py -> Improved user profile loading with missing key checks. 🛠️ tests/test_decision_service.py -> Updated tests to include user profile tracker.

optimizely/decision_service.py -> fixed get_variations_for_feature_list

c67bcf3

optimizely/decision_service.py -> Fixed how rollout reasons are added

820ba3e

tests/test_decision_service.py -> Added user profile tracker object

tests/test_user_context.py -> fixed some tests

309223c

optimizely/user_profile.py -> Updated type for experiment_bucket_map.

ca1b248

tests/test_decision_service.py -> Fixed tests

all unit tests passing

d0bc332

FarhanAnjum-opti requested a review from a team as a code owner November 13, 2024 15:51

optimizely-codereview-bot assigned FarhanAnjum-opti Nov 13, 2024

FarhanAnjum-opti added 7 commits November 13, 2024 22:00

lint check

e6e442a

fix: typechecks added

0c92722

more types updated

af9715e

all typechecks passing

e2d7c91

gha typechecks fixed

cc4da7e

all typecheck should pass

dd62075

lint check should pass

2477d11

Mat001 requested changes Nov 20, 2024

View reviewed changes

FarhanAnjum-opti added 2 commits November 21, 2024 01:11

removed unnecessary comments

27ef846

removed comments from test

e2810c8

raju-opti requested changes Nov 21, 2024

View reviewed changes

optimizely/decision_service.py Outdated Show resolved Hide resolved

optimizely/optimizely.py Show resolved Hide resolved

optimizely/optimizely.py Show resolved Hide resolved

FarhanAnjum-opti added 3 commits November 21, 2024 23:38

optimizely/decision_service.py -> Removed user profile save logic

9228727

optimizely/optimizely.py -> Added loading and saving profile logic

optimizely/user_profile.py -> Updated experiment_bucket_map type

b33a92b

optimizely/user_profile.py -> Testing user profile update logic

optimizely/decision_service.py -> Commented out profile loading

1dd1eef

optimizely/user_profile.py -> Removed unused import statement

FarhanAnjum-opti requested review from raju-opti and Mat001 November 25, 2024 17:30

optimizely/user_profile.py -> Reverted back to variation ID retrieval…

8359498

… logic.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FSSDK-10763] Implement UPS request batching for decideForKeys #440

[FSSDK-10763] Implement UPS request batching for decideForKeys #440

FarhanAnjum-opti commented Nov 13, 2024

Mat001 left a comment

[FSSDK-10763] Implement UPS request batching for decideForKeys #440

Are you sure you want to change the base?

[FSSDK-10763] Implement UPS request batching for decideForKeys #440

Conversation

FarhanAnjum-opti commented Nov 13, 2024

Summary

Test plan

Issues

Mat001 left a comment

Choose a reason for hiding this comment