Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10642] Refactor batch event processor #960

Merged
merged 45 commits into from
Nov 21, 2024
Merged

[FSSDK-10642] Refactor batch event processor #960

merged 45 commits into from
Nov 21, 2024

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Nov 14, 2024 •
edited
Loading

Summary

  • The batch event processor has been refactored. Updates include:
    • dispatch retry
    • pending event retry logic moved from dispatcher to processor

Test plan

  • added new tests

Issues

  • FSSDK-10642

@raju-opti raju-opti requested a review from a team as a code owner November 14, 2024 18:59
@raju-opti raju-opti marked this pull request as draft November 14, 2024 18:59
@raju-opti raju-opti changed the title Raju/queueing event processor [FSSDK-10642] Refactor batch event processor Nov 20, 2024
@raju-opti raju-opti marked this pull request as ready for review November 20, 2024 19:01
mikechu-optimizely
mikechu-optimizely approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but woof that was long.

No showstoppers, just some thoughts 👇

lib/event_processor/batch_event_processor.react_native.spec.ts Outdated Show resolved Hide resolved
lib/event_processor/eventProcessor.ts Outdated Show resolved Hide resolved
lib/event_processor/eventProcessor.ts Outdated Show resolved Hide resolved
lib/event_processor/event_processor_factory.browser.spec.ts Show resolved Hide resolved
lib/event_processor/event_processor_factory.node.ts Show resolved Hide resolved
lib/utils/http_request_handler/http_util.ts Show resolved Hide resolved
lib/utils/id_generator/index.ts Show resolved Hide resolved
lib/utils/type.ts Show resolved Hide resolved
lib/index.node.tests.js Show resolved Hide resolved
lib/index.node.ts Outdated Show resolved Hide resolved
@raju-opti raju-opti merged commit af9fcab into master Nov 21, 2024
9 of 14 checks passed
@raju-opti raju-opti deleted the raju/queueing_event_processor branch November 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@junaed-optimizely junaed-optimizely Awaiting requested review from junaed-optimizely

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raju-opti @mikechu-optimizely