IFC-993 Fix uniqueness constraint with enum attributes #5195
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5195 will not alter performanceComparing Summary
|
The actual value of the enum member was not checked. Instead a string representation of the member was used, which was causing the database query to never match any nodes.
gmazoyer
force-pushed
the
gma-20241211-ifc993
branch
from
890b8a4 to
fb26b6f
Compare
ajtmccarty
approved these changes
Dec 12, 2024
backend/tests/unit/core/constraint_validators/test_node_grouped_uniqueness.py
Show resolved
Hide resolved
gmazoyer
added a commit
that referenced
this pull request
Dec 12, 2024
The actual value of the enum member was not checked. Instead a string representation of the member was used, which was causing the database query to never match any nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual value of the enum member was not checked. Instead a string representation of the member was used, which was causing the database query to never match any nodes.