Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Search Anywhere component #5175

Merged
merged 2 commits into from
Dec 10, 2024
Merged

refactor Search Anywhere component #5175

merged 2 commits into from
Dec 10, 2024

Conversation

bilalabbad
Copy link
Contributor

@bilalabbad bilalabbad commented Dec 10, 2024 •
edited
Loading

  • Used cmdk everywhere
  • split initial big component into smaller well-scoped components
  • introduce @tanstack/query for fetching
  • improved search anywhere context and how to consume it
  • better navigation
  • Better variable naming
  • some fixes
    • FIX: open search anywhere with shortcut in firefox
    • FIX: broken keyboard navigation when 2 search results have the same kind
    • FIX: conflicting style when navigating with keyboard + hovering with mouse

@bilalabbad bilalabbad added group/frontend Issue related to the frontend (React) type/housekeeping Maintenance task labels Dec 10, 2024
@bilalabbad bilalabbad self-assigned this Dec 10, 2024
@bilalabbad bilalabbad merged commit 846a428 into release-1.0.9-beta Dec 10, 2024
29 checks passed
@bilalabbad bilalabbad deleted the bab-refactor-search-anywhere branch December 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bilalabbad bilalabbad

Labels
group/frontend Issue related to the frontend (React) type/housekeeping Maintenance task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bilalabbad