refactor ipam unit tests to maintain data #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
ajtmccarty
changed the title
CodSpeed Performance ReportMerging #5163 will not alter performanceComparing Summary
|
LucasG0
reviewed
Dec 10, 2024
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| async def default_branch(local_storage_dir: str, db: InfrahubDatabase) -> Branch: |
There was a problem hiding this comment.
Should function body of these fixtures be factorized into new functions to avoid duplication of backend.tests.helpers original fixtures?
There was a problem hiding this comment.
good suggestion, I've made that change
LucasG0
reviewed
Dec 10, 2024
| @@ -0,0 +1,58 @@ | |||
| from typing import Any | |||
There was a problem hiding this comment.
If this query is used only for testing purposes, I think it should be located under tests
There was a problem hiding this comment.
it's tricky because the goal is to expose it to other systems during integration tests so from Infrahub point of view it's not just for testing
LucasG0
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work from hackathon
adds a new query to reset a database to specific time by hard-deleting any changes after that time
updates some IPAM unit tests to use this new query to speed up some unit tests
would like to follow it up with a mutation that allows doing this, but will require some more work to support updating cached data correctly. made an issue for it here IFC-998