Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert EventBranchRebased to InfrahubEvent #5088

Open
wants to merge 5 commits into
base: release-1.1
Choose a base branch
from
Open

Convert EventBranchRebased to InfrahubEvent #5088

wants to merge 5 commits into from

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Nov 28, 2024

I missed play with commits and it was finally easier to create a new PR, not force pushing into #4906 to keep a reference.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 28, 2024
@dgarros
Copy link
Collaborator

dgarros commented Nov 28, 2024

would be good to have it in release1.1

@LucasG0 LucasG0 force-pushed the lgu-copy-rebase branch 2 times, most recently from bf542fd to 907a6ed Compare November 29, 2024 11:40
@github-actions github-actions bot added type/documentation Improvements or additions to documentation group/frontend Issue related to the frontend (React) group/ci Issue related to the CI pipeline labels Nov 29, 2024
@LucasG0 LucasG0 changed the base branch from develop to release-1.1 November 29, 2024 11:41
@github-actions github-actions bot removed type/documentation Improvements or additions to documentation group/frontend Issue related to the frontend (React) labels Nov 29, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5088 will not alter performance

Comparing lgu-copy-rebase (369bce4) with release-1.1 (65aa5aa)

Summary

✅ 10 untouched benchmarks

@dgarros dgarros mentioned this pull request Nov 30, 2024
Closed
@LucasG0 LucasG0 mentioned this pull request Dec 2, 2024
Merged
@github-actions github-actions bot removed the group/ci Issue related to the CI pipeline label Dec 3, 2024
@LucasG0 LucasG0 force-pushed the lgu-copy-rebase branch 2 times, most recently from a6ee0d7 to a23db45 Compare December 3, 2024 10:16
@LucasG0 LucasG0 marked this pull request as ready for review December 3, 2024 10:43
@LucasG0 LucasG0 requested a review from a team December 3, 2024 10:44
LucasG0
LucasG0 commented Dec 3, 2024
View reviewed changes
backend/infrahub/core/diff/payload_builder.py
labels = await get_display_labels_per_kind(kind=kind, ids=ids, db=db, branch_name=branch_name)
labels = await get_display_labels_per_kind(
kind=kind, ids=ids, db=db, branch_name=branch_name, skip_missing_schema=True
)
response[branch_name].update(labels)

return response
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file correspond to a cherry pick of #5128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasG0 @dgarros @FragmentedPacket @ajtmccarty