Enforce repo management permission #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
gmazoyer
commented
Nov 18, 2024
Comment on lines
30
to
54
| if action != "view": | ||
| if node.kind in (InfrahubKind.ACCOUNTGROUP, InfrahubKind.ACCOUNTROLE, InfrahubKind.GENERICACCOUNT) or ( | ||
| node.inherit_from and InfrahubKind.GENERICACCOUNT in node.inherit_from | ||
| ): | ||
| return ( | ||
| BranchRelativePermissionDecision.ALLOW | ||
| if global_permission_report[GlobalPermissions.MANAGE_ACCOUNTS] | ||
| else BranchRelativePermissionDecision.DENY | ||
| ) | ||
| if node.kind in (InfrahubKind.BASEPERMISSION, InfrahubKind.GLOBALPERMISSION, InfrahubKind.OBJECTPERMISSION) or ( | ||
| node.inherit_from and InfrahubKind.BASEPERMISSION in node.inherit_from | ||
| ): | ||
| return ( | ||
| BranchRelativePermissionDecision.ALLOW | ||
| if global_permission_report[GlobalPermissions.MANAGE_PERMISSIONS] | ||
| else BranchRelativePermissionDecision.DENY | ||
| ) | ||
| if node.kind in (InfrahubKind.GENERICREPOSITORY, InfrahubKind.REPOSITORY, InfrahubKind.READONLYREPOSITORY) or ( | ||
| node.inherit_from and InfrahubKind.GENERICREPOSITORY in node.inherit_from | ||
| ): | ||
| return ( | ||
| BranchRelativePermissionDecision.ALLOW | ||
| if global_permission_report[GlobalPermissions.MANAGE_REPOSITORIES] | ||
| else BranchRelativePermissionDecision.DENY | ||
| ) |
There was a problem hiding this comment.
Probably not the prettiest code to achieve that.
CodSpeed Performance ReportMerging #4976 will not alter performanceComparing Summary
|
|
Looks like the E2E tests don't like something about this, they've failed with this error twice: |
ajtmccarty
approved these changes
Nov 18, 2024
gmazoyer
added a commit
that referenced
this pull request
Nov 19, 2024
Also fix permission report for kinds relying on global permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.