Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PrefixPool with netaddr.IPSet #4896

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

PhillSimonds
Copy link

Fixes #3547

backend/infrahub/pools/prefix.py Outdated Show resolved Hide resolved
backend/infrahub/pools/prefix.py Outdated Show resolved Hide resolved
backend/infrahub/pools/prefix.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4896 will improve performances by 21.14%

Comparing PhillSimonds:ps-issue-3547 (2596f90) with develop (485838f)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark develop PhillSimonds:ps-issue-3547 Change
test_schemabranch_duplicate 377.9 µs 312 µs +21.14%

@gmazoyer gmazoyer added the type/housekeeping Maintenance task label Nov 18, 2024
@gmazoyer gmazoyer self-assigned this Nov 18, 2024
@PhillSimonds PhillSimonds requested a review from a team as a code owner December 2, 2024 15:39
@gmazoyer
Copy link
Contributor

gmazoyer commented Dec 5, 2024

Seeing the tests still failing, I wonder if switching to IPSet actually fixes some bug we did not know about. I'll have a deeper look.

@gmazoyer
Copy link
Contributor

gmazoyer commented Dec 5, 2024

Seeing the tests still failing, I wonder if switching to IPSet actually fixes some bug we did not know about. I'll have a deeper look.

Having gone through the changes, I believe the test failures actually highlight wrong expected results in the first place. We should therefore fix these wrong expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/housekeeping Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Replace class PrefixPool -> netaddr.IPSet
2 participants